feat(react): add Listbox component #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview branch generated at https://listbox.d1gko6en628vir.amplifyapp.com |
scurker
force-pushed
the
listbox
branch
9 times, most recently
from
99df32d
to
fe0c258
Compare
dequejosie
reviewed
Aug 23, 2023
dequejosie
reviewed
Aug 23, 2023
dequejosie
reviewed
Aug 23, 2023
dequejosie
reviewed
Aug 23, 2023
dequejosie
reviewed
Aug 23, 2023
dequejosie
reviewed
Aug 23, 2023
dequejosie
reviewed
Aug 23, 2023
dequejosie
reviewed
Aug 23, 2023
dequejosie
reviewed
Aug 23, 2023
dequejosie
reviewed
Aug 23, 2023
scurker
changed the title
thuey
reviewed
Aug 24, 2023
thuey
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
Assuming #1167 (comment) is okay, this LGTM. Nice job! This is pretty cool.
|
Preview branch generated at https://listbox.d1gko6en628vir.amplifyapp.com |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1088
Listboxwill be one of the driving behaviors behindComboboxto provide that set of functionality for the combobox list. Eventually, we can also refactorOptionMenuto also utilize this component as well to help consolidate these types of behaviors within a single component.