-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): upgrade eslint #1089
chore(deps): upgrade eslint #1089
Conversation
Thanks for contributing @jmetev1! Normally we would have you apply via our careers page, but I'm not sure where our active listings are. Would you mind submitting your resume to [email protected] ccing [email protected]? We'd love to have you apply! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing to cauldron! We are admittedly a little behind on updating some of our dependencies, so this is a big help. Requested changes below:
this is one of those times where the ui shows "all conversations resolved", but also "scurker requests changes". Is there anything else i need to do here? |
Our process normally has been to have the submitter dismiss the changes, but I'm taking a look right now to ensure we're good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your help here!
🚨 Reviewed For Security 🚨 |
Hi folks. I see you're hiring. Does this qualify me for an interview for https://www.deque.com/careers/senior-full-stack-developer/ ?
closes #451
I upgraded eslint and plugins. Of course this comes with some new rules and changes. To deal with that I disabled some rules that you were not using previously and made a few other small changes. Let me know if you want any changes. Or just push them.