diff --git a/packages/react/__tests__/src/components/Notice/index.js b/packages/react/__tests__/src/components/Notice/index.js index 9407983e4..0d1647236 100644 --- a/packages/react/__tests__/src/components/Notice/index.js +++ b/packages/react/__tests__/src/components/Notice/index.js @@ -52,17 +52,6 @@ test('should return correctly with props passed in', async () => { expect(wrapper.prop('children')).toBe('bar'); }); -test('should fallback to the `info-circle` icon when an invalid icon type is passed in', async () => { - const wrapper = mount( - - bar - - ); - - expect(wrapper.find('Notice').length).toBe(1); - expect(wrapper.find('Icon').prop('type')).toBe('info-circle'); -}); - test('should render with the correct icon when a valid icon `type` string is passed in', async () => { const wrapper = mount(); diff --git a/packages/react/src/components/Notice/index.tsx b/packages/react/src/components/Notice/index.tsx index 26558ee82..6e9565461 100644 --- a/packages/react/src/components/Notice/index.tsx +++ b/packages/react/src/components/Notice/index.tsx @@ -31,9 +31,7 @@ const Notice = forwardRef( {...otherProps} >
- + {title}
{children && typeof children === 'string' ? ( @@ -53,11 +51,9 @@ Notice.propTypes = { type: PropTypes.oneOf(['caution', 'info']), // @ts-expect-error title: PropTypes.oneOf([ - 'string', - 'number', - 'ReactElement', - 'ReactFragment', - 'ReactPortal' + PropTypes.string, + PropTypes.number, + PropTypes.element ]), // @ts-expect-error icon: PropTypes.string diff --git a/packages/styles/notice.css b/packages/styles/notice.css index 7de383321..4fcf28755 100644 --- a/packages/styles/notice.css +++ b/packages/styles/notice.css @@ -19,7 +19,7 @@ .Notice { display: block; - padding: var(--space-small) var(--space-small); + padding: var(--space-smaller) var(--space-small); border: 1px solid var(--notice-border-color); background-color: var(--notice-background-color); color: var(--notice-text-color);