-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Choppy performance in a third party component after introducing axe-core #886
Comments
Hi @ashishbairwa we will look into this issue and provide an update when possible. |
Hey @ashishbairwa have you tried updating to the latest version of |
Hey @michael-siek , In sandbox I've used the latest available version 4.8.1 and it's happening on it. |
@ashishbairwa I tried to experiment with the codesandbox. It looks like when the emoji picker is open axe is constantly running in the background, and even takes up 100% of the CPU. I tried to run axe just by itself and it takes ~800ms to run when the emoji picker is open, so I'm surprised that it's always running. My current guess is that there is an element on the page that is constantly refreshing / reloading and causing our DOM watcher to constantly fire. I noticed the chat feature is frequently showing a connection error, so that might help contribute to the problem. Would you be able to figure out what the constant DOM reloading is and see if removing the problem also fixes the axe performance problem? |
Sure @straker , but could you please shed some light on how your dom watcher actually works? What kind of events do you actually look for? If you can point me to the line of code where the dom watcher is implemented. Maybe I can put some debug logs to pin point the events |
Sure. Our code overrides the |
Product
react
Product Version
4.4.2
Latest Version
Issue Description
Expectation
Actual
After introducing axe-core into our project which is using stream-chat-react, we are facing a visible lag in the performance of emoji picker. On profiling the performance, we can see a function is constantly getting invoked from axe without any specific errors in the console
How to Reproduce
Here is the reproducible demo link https://codesandbox.io/s/bold-tesla-3mtyhf
Steps to reproduce the issue:
Demo video - https://youtu.be/tWQtOKuJlZ4
Please find all the traces in the attachments. It includes snapshot and traces from performance profiler
Trace-with emoji picker opened.json
Additional context
Stream chat react - https://www.npmjs.com/package/stream-chat-react
Stream chat official website - https://getstream.io/chat/docs/sdk/react/
The text was updated successfully, but these errors were encountered: