Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rate limiting monitor for Search #19414

Open
3 tasks
jilladams opened this issue Oct 4, 2024 · 0 comments
Open
3 tasks

Create rate limiting monitor for Search #19414

jilladams opened this issue Oct 4, 2024 · 0 comments
Labels
Blocked Issues that are blocked on factors other than blocking issues. Monitoring Needs refining Issue status Public Websites Scrum team in the Sitewide crew sitewide VA.gov Search Search.gov integration, owned by Public Websites team

Comments

@jilladams
Copy link
Contributor

jilladams commented Oct 4, 2024

[2024-10-04] Blocked on confirming our rate limit with Search.gov and completing cutover to the new API endpoint

Description

Today when we moved to the new search API endpoint (#18736) , we hit a rate limit, but we didn't get a forewarning. We learned it when the VA.gov - Search Browser Test alarmed, showing that Search calls in the browser were failing.

We don't have an alarm that explicitly goes off related to Search rate limiting and we probably should.

We do this for VA Forms: https://vagov.ddog-gov.com/monitors/160407, based on the rate limit for LH API user key. The monitor counts calls to the API every minute, warning at 400, alarming at 450.

We already know we have weird rate limiting problems with the search_click_tracking endpoint (#14819), and that doesn't appear to affect traffic to the actual search endpoint / get it rate limited. Maybe our rate limits are per endpoint? Or if they're per API key, we are using different keys per endpoint?

Either way, there's some kind of current firewall between v0/search and search_click_tracking already, so once Search.gov verifies our rate limits for v0/search to the new gsa endpoint, we could set up a monitor similar to the Forms one.

ACs

@jilladams jilladams added Needs refining Issue status Public Websites Scrum team in the Sitewide crew sitewide VA.gov Search Search.gov integration, owned by Public Websites team Monitoring Blocked Issues that are blocked on factors other than blocking issues. labels Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked Issues that are blocked on factors other than blocking issues. Monitoring Needs refining Issue status Public Websites Scrum team in the Sitewide crew sitewide VA.gov Search Search.gov integration, owned by Public Websites team
Projects
None yet
Development

No branches or pull requests

1 participant