Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft detailed content spec for expanded police contact information #16812

Closed
4 of 7 tasks
davidmpickett opened this issue Jan 10, 2024 · 9 comments
Closed
4 of 7 tasks
Assignees
Labels
Content model [CMS feature] The bones of the CMS Facilities Facilities products (VAMC, Vet Center, etc) sitewide UX VAMC police transparency Sub-product of VAMC

Comments

@davidmpickett
Copy link
Contributor

davidmpickett commented Jan 10, 2024

User Story or Problem Statement

AS A Drupal Engineer
I NEED detailed guidance on how VA police contact information will work as a VAMC non-clinical service
SO THAT I can implement it in Drupal

Description or Additional Context

#16415

Acceptance Criteria

  • Fields and field properties and documented
  • Reviewed with engineering & product
  • Subsequent tickets are updated
  • [ ] (Possibly) send to CMS Collab Cycle

Team

Please check the team(s) that will do this work.

  • CMS Team
  • Public Websites
  • Facilities
  • Accelerated Publishing
@davidmpickett davidmpickett added Content model [CMS feature] The bones of the CMS Facilities Facilities products (VAMC, Vet Center, etc) Needs refining Issue status UX VAMC police transparency Sub-product of VAMC labels Jan 10, 2024
@davidmpickett davidmpickett changed the title Draft detailed content spec for police contact information Draft detailed content spec for expanded police contact information Jan 10, 2024
@davidmpickett davidmpickett removed the Needs refining Issue status label Jan 16, 2024
@davidmpickett davidmpickett self-assigned this Jan 17, 2024
@davidmpickett
Copy link
Contributor Author

davidmpickett commented Jan 30, 2024

Step 1 - Add the term to the Service taxonomy

Step 2 - Create a new Display on a View

  • View: non_clinical_services
  • Display: Should be able to copy one of the 3 existing Displays. Only a few fields should need to change:
    • Display name: VA Police
    • Machine Name: va_police
    • Title: @davidmpickett will provide text
    • filter criterion: Content: Service -> Will need to bee set to VA Police once Term is added in Step 1
    • Header: Global: Text area - @davidmpickett will provide text
    • Footer: Global: Text area - @davidmpickett will provide text
    • No results behavior: Global: Text area - @davidmpickett will provide text

Here's an annotated screenshot of how the text fields in the Display will show up in the editorial experience

300649297-c83160f9-c047-4602-9dd9-6a81ec4753b6

Step 3 - Update the Content Type

  • Content Type: VAMC System VA Police page
  • Add a new Viewfield field similar to the Non-Clinical Services field on the content types VAMC System Billing and Insurance, Register for Care, and Medical Records.
    • This should be in the Contact information fieldset after the Contact phone number
    • Mostly just copy and pasting the settings here. Only real difference is the Display.
    • Field label: Non-clinical Services
    • Machine name: field_non_clinical_services
    • Always use default value ✅
    • Display the default value on node edit ✅
    • Allowed display types: Block
    • Set default value ✅
      • View: non-clinical services
      • Display: "VA Police" created in Step 2
      • Advanced options: [node:field_office:target_id]/[node:field_administration:target_id]
  • Update: Contact phone number field
    • Add guidance on what should go here (a single best point of contact for the whole system)
    • Make this field editable (remove from the External Content tooltip)
    • Some kind of required logic that makes this field OR a non-clinical service required?
      • For those systems that basically have two equally important numbers, should we allow them to leave the System phone number blank if they've provided more Non clinical services?

Examples of existing non-clinical services blocks on VAMC System top task pages

Screenshot 2024-01-29 at 7 06 29 PM

@davidmpickett
Copy link
Contributor Author

davidmpickett commented Jan 30, 2024

End of sprint 102 update - did some initial research and docmentation. Still have work to do, but have a good handle on the scope. 2 point done, 3 left for 103

@jilladams @xiongjaneg

@davidmpickett
Copy link
Contributor Author

Shared on slack for review https://dsva.slack.com/archives/C0FQSS30V/p1707174166038499

@swirtSJW
Copy link
Contributor

swirtSJW commented Feb 6, 2024

I looked at the model and it makes sense to me, though it should really be @omahane who gives it a looky see.

@davidmpickett
Copy link
Contributor Author

davidmpickett commented Feb 9, 2024

@mmiddaugh @aklausmeier

Questions that I raised in UX Sync:

1) Is Drupal now the source of truth for VA Police contact information?

  • Will we ever again need to import data from the CSV maintained by Office of Security and Law Enforcement?
  • Do we need to provide an export of the data in Drupal to them for any reporting processes?
  • This isn't the most urgent question to answer, but it may impact some aspects of Drupal implementation
Screenshot 2024-02-09 at 12 39 31 PM
  1. How will system-level and facility-level contact information play together?
  • As we move to a model where contact information can be facility specific (but doesn't have to be), are we keeping the requirement of one number per system?
  • For those systems that basically have two equally important numbers, should we allow them to leave the system phone number blank if they've provided facility-specific information via Non-clinical services? e.g. Some kind of required logic that makes system-level field OR a non-clinical service required?
  • Do we want facility-specific information to be filtered dynamically by facility? Or are we keeping it all in the static portion of the page?
Screenshot 2024-02-09 at 12 41 45 PM

@davidmpickett
Copy link
Contributor Author

davidmpickett commented Feb 9, 2024

@xiongjaneg - I have shared this for review and updated following tickets:

I assume we're not going take this to CMS collab cycle given everything going on right now, but it's one of the default ACs for any content model change, so want to make sure you make that call officially.

@xiongjaneg
Copy link
Contributor

Yup, removing that AC for now. Just met with Grace the CMS Team PM and they're working on incorporating into the Platform collab cycle process, so lots tbd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content model [CMS feature] The bones of the CMS Facilities Facilities products (VAMC, Vet Center, etc) sitewide UX VAMC police transparency Sub-product of VAMC
Projects
None yet
Development

No branches or pull requests

4 participants