Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile View for header "My account" dropdown has truncated display issues #16580

Closed
2 tasks
chriskim2311 opened this issue Dec 28, 2023 · 3 comments
Closed
2 tasks

Mobile View for header "My account" dropdown has truncated display issues #16580

chriskim2311 opened this issue Dec 28, 2023 · 3 comments
Assignees
@chriskim2311
Labels
Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area

Comments

@chriskim2311
Copy link
Contributor

chriskim2311 commented Dec 28, 2023 •
edited
Loading

Description

For LOA1 accounts they see a truncated M... AND (Email)... for their my account dropdown in mobile views.

image (1).png

Acceptance criteria

  • Fix CSS so that the My Account span shows properly in mobile view.
  • Ensure that for all screen sizes that either Email or My Account is shown not both at the same time.
@chriskim2311 chriskim2311 added Public Websites Scrum team in the Sitewide crew VA.gov frontend CMS team practice area labels Dec 28, 2023
@andaleliz
Copy link

@chriskim2311 I think the span you're talking about is this one:

<span class="small-screen:vads-u-visibility--visible medium-screen:vads-u-display--none">My Account</span>

Just curious, what are the use cases in which it would show? I know for authenticated LOA3 users it shows their first name, and I can't think of a time when I've seen the words "My Account" displayed in the header.

@jilladams jilladams changed the title Mobile View for header my account dropdown has truncated display issues Mobile View for header "My account" dropdown has truncated display issues Jan 11, 2024
@chriskim2311 chriskim2311 self-assigned this Jan 11, 2024
@chriskim2311 chriskim2311 mentioned this issue Jan 12, 2024
Merged
13 tasks
@chriskim2311
Copy link
Contributor Author

Having trouble testing this it will carry over to next sprint

@chriskim2311
Copy link
Contributor Author

Verified in prod, closing!
My_VA___Veterans_Affairs.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chriskim2311 chriskim2311

Labels
Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chriskim2311 @andaleliz @jilladams