Drupal: Update police page for MVP showing contact information and FAQs

[xiongjaneg]

Description or Additional Context

In 12/6 sprint planning, it was decided that MVP for the police page would include:

• system page listing police contact information for facilities in that system
  • based on what the data gives us to work with, this will likely be a phone field or use the phone paragraph with unlimited cardinality.
• FAQs no change needed for this one.

This ticket is to update Drupal to include only that information for MVP.

Will go in two PRs

• 1) VACMS-16335 va police contact #16360 adding field to unblock FE (this PR)
• 2) add migration (separate PR) VACMS-16335 Add VAMC System police contact migration #16430

Acceptance Criteria

• Contact list csv is formatted and cleaned up.
  • For contact number use the Telephone Ops column. One number per system for MVP.
  • API ID column is added.
• Appropriate field is added to the VA Police content type
• migration is written to populate all the system pages from the CSV (approach to be determined based on the csv structure.

[swirtSJW]

Estimated 5 based on assuming easy to conneect data in the csv. May need to be adjusted if the data turns out to be gnarly.

[swirtSJW]

Discuss with @davidmpickett as to the field types for the data, keeping in mind two possibly opposing directions:

• simple phone and title field
  • easiest to implement
  • easiest to sync up on subsequent migrations
  • easiest for FE to pull into their react data
• phone number paragraph
  • syncing paragraphs in subsequent runs of a migration is challenging
  • pulling that data into the react data is a bit more challenging due to entity references.

[xiongjaneg]

@swirtSJW @omahane Example of contact info from Police
VAP Chief - Facility Contact List (12-5-2023).csv

Police guidance is to use the Telephone Ops number.

[davidmpickett]

Have to pause for a couple meetings, but I'm almost done with an initial pass of assigning a VAMC System to every meaninful line from the CSV
va-gov-cms-vamc-facilities.csv

[davidmpickett]

Took a first pass of cleaning up the CSV and indicating the most likely VAMC System and Facility ID string* for each line item. I also found any systems that have multiple line items are marked them as either good duplicate (aka there are multiple entries, but they all have the same phone number) or needs decision. Looks like there at 10 VAMC systems with multiple entries where we will need our police stakeholders to make a decision on which one to show for mmmVP

New Source of Truth for cleaned CSV

Static copy for convenience

[xiongjaneg]

Will this need UX and a11y review?

[swirtSJW]

Will this need UX and a11y review

@xiongjaneg Ideally yes, but given time frame and the fact that no editor will interact with this data in any way, I would say we could probably skip it for now.

[davidmpickett]

@swirtSJW @omahane and I met today. We went back and forth on a simple phone field or the phone paragraph type, they both have pros and cons. Then Steve realized a technical consideration that might make the paragraph type not a meaningful option. But he needs to test a thing first

[swirtSJW]

There is a bug... or maybe an unrecalled feature where external content it being inserted at the top of the page, despite the weighting showing that it should come after the title and field office.

Given the urgency of police AND that no editors will be in this for a long time, I am going to move on and not chase this bug down.

It is in the right spot for true admins, just not any other editors

[davidmpickett]

Want to note that the bug is only on the Edit screen and not on Node view. If we took edit permissions away from Content Editor, Reviewer, Publisher (which we previously waffled on) on this content type, then that would prevent most editors from seeing this weirdness

[swirtSJW]

The bug Dave mentions above is no more. Resolved.

[jilladams]

FAQs already in place.
Migrations in progress, unblocked now. ETA for code review by ~Fri.

[swirtSJW]

Updated upstream data and here is a copy to get into my space
police_system_contacts.csv

[swirtSJW]

The final PR has been merged. We will just need to run the migration by hand after the code deploys today.

[swirtSJW]

The contact migration has been run on prod and all is good

We can call this done.