Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target parameter has to be used instead of service_data for shortcuts (wrong parameter order) #378

Open
philw07 opened this issue Jul 21, 2024 · 1 comment

Comments

@philw07
Copy link

philw07 commented Jul 21, 2024

Thanks for this card.
I just noticed that the target and service_data parameters are in the wrong order in this call.

this.callService(service, target, service_data);

Function signature with different order here:

private callService(

I added shortcuts for oscillation (target not used) and wondered why they weren't working, but then noticed I actually had to use target instead of service_data due to this issue

  - name: Oscillate On
    icon: mdi:arrow-oscillating
    service: fan.oscillate
    target:
      oscillating: true
@trablin45
Copy link

thanks for your comments, I was able to update my broken card with this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants