Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running "create-next-app" without permissions flags causes terminal to crash #25185

Open
thisisjofrank opened this issue Aug 23, 2024 · 13 comments
Labels
bug Something isn't working correctly permissions related to --allow-* flags

Comments

@thisisjofrank
Copy link
Contributor

Version: Deno 1.46.0

If I try to run

deno run npm:create-next-app@latest my-next-app

and walk through the permissions prompts, after the final prompt the program hangs and crashes the terminal.

Note: deno run -A npm:create-next-app@latest my-next-app runs absolutely fine.

@littledivy littledivy added bug Something isn't working correctly permissions related to --allow-* flags windows Related to Windows platform labels Aug 23, 2024
@yazan-abdalrahman
Copy link
Contributor

yazan-abdalrahman commented Aug 25, 2024

@thisisjofrank @littledivy @bartlomieju @dsherret
It works, and it asks for a lot of permission, so I don't think it an issue, and I assume no one will try to use it without -A.

image
image

@thisisjofrank
Copy link
Contributor Author

Doesn't work on my machine... Once I get through all the permissions prompts it hangs on the 'would you like to use TypeScript prompt and then the entire terminal crashes

In both bash and powershell on windows.

@yazan-abdalrahman
Copy link
Contributor

Doesn't work on my machine... Once I get through all the permissions prompts it hangs on the 'would you like to use TypeScript prompt and then the entire terminal crashes

In both bash and powershell on windows.

For me, I can't reproduce it.

@dsherret @bartlomieju

@marvinhagemeister
Copy link
Contributor

Can reproduce it on my windows machine in powershell.

@yazan-abdalrahman
Copy link
Contributor

yazan-abdalrahman commented Aug 26, 2024

Can reproduce it on my windows machine in powershell.

@marvinhagemeister
If you put one of the permission prompts n, it will crash, but if you put all permissions y, it will operate properly.

 how many prompts it will accept?
since it supplies too many prompts.

I believe this case not applicable, it will not actually issue,

@marvinhagemeister
Copy link
Contributor

I ran into the scenario where I accepted all prompts individually, but was stuck at the Would you like to use TypeScript prompt. I couldn't even move the cursor between the choices and the whole process was unresponsive to any keyboard input. I cannot reliably reproduce it though. Seems to sometimes happen, sometimes not.

@yazan-abdalrahman
Copy link
Contributor

yazan-abdalrahman commented Aug 26, 2024

deno.flags.rs.2024-08-26.14-52-52.mp4

@marvinhagemeister

@yazan-abdalrahman
Copy link
Contributor

yazan-abdalrahman commented Aug 26, 2024

deno.flags.rs.2024-08-26.14-55-51.-.Trim.mp4

@yazan-abdalrahman
Copy link
Contributor

image

@marvinhagemeister
Copy link
Contributor

Sounds like this is a tricky one to reproduce reliably, or the exact reproduction steps haven't been found yet.

@thisisjofrank
Copy link
Contributor Author

Even if I Y or A all permission as they prompt it still crashes at "would you like to use typescript" and the cursor can't move between, as @marvinhagemeister experienced.

@thisisjofrank
Copy link
Contributor Author

Happy to jump on a call and show you if it's helpful?

@littledivy littledivy removed the windows Related to Windows platform label Oct 10, 2024
@littledivy
Copy link
Member

Reproducible on macOS too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly permissions related to --allow-* flags
Projects
None yet
Development

No branches or pull requests

4 participants