Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send/receive: use io.ReadCloser and io.WriteCloser instead of io.Reader / io.Writer #7

Open
casKd-dev opened this issue Aug 19, 2024 · 0 comments
Labels

Comments

@casKd-dev
Copy link
Contributor

Current implementation of send/receive hangs until exit due to the stream never being closed, thus blocking indefinetly. For these functions the data types implementing io.Close() should be used and stream closures propagated accordingly.

Unsure about the file descriptor provided by the raw ioctl() call but go's cmd.Exec / cmd.Run requires directly using the o.StdoutPipe() so that Close() is propagated accordingly.

@dennwc dennwc added the bug label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants