Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle potential serialization errors in FinalizedEpoch::insert_signature #127

Open
coderabbitai bot opened this issue Sep 23, 2024 · 0 comments
Open
Assignees

Comments

@coderabbitai
Copy link

coderabbitai bot commented Sep 23, 2024

The method FinalizedEpoch::insert_signature uses unwrap() on the result of bincode::serialize, which can cause a panic if serialization fails. It's better to handle this error to prevent unexpected crashes and improve the robustness of the code.

This issue was identified during discussion in PR #123 by @coderabbitai[bot]. Please refer to the comment here for more details.

Requested by @distractedm1nd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant