Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Deprecated ioutil package #280

Merged
merged 1 commit into from
May 29, 2024
Merged

Remove Deprecated ioutil package #280

merged 1 commit into from
May 29, 2024

Conversation

chimanjain
Copy link
Contributor

@chimanjain chimanjain commented May 29, 2024 •
edited
Loading

Description

Remove Deprecated ioutil package

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1221

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@csmbot
Copy link
Collaborator

csmbot commented May 29, 2024

Can one of the admins verify this patch?

HarishH-DELL
HarishH-DELL approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@HarishH-DELL HarishH-DELL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dell dell deleted a comment from alikdell May 29, 2024
@shaynafinocchiaro
Copy link
Collaborator

e2e pass

@shaynafinocchiaro shaynafinocchiaro merged commit fd7cb3b into main May 29, 2024
15 checks passed
@shaynafinocchiaro shaynafinocchiaro deleted the remove-ioutil-package branch May 29, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alikdell alikdell alikdell approved these changes

@shaynafinocchiaro shaynafinocchiaro shaynafinocchiaro approved these changes

@boyamurthy boyamurthy boyamurthy approved these changes

@HarishH-DELL HarishH-DELL HarishH-DELL approved these changes

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@EvgenyUglov EvgenyUglov Awaiting requested review from EvgenyUglov EvgenyUglov is a code owner

@bjiang27 bjiang27 Awaiting requested review from bjiang27 bjiang27 is a code owner

@xuluna xuluna Awaiting requested review from xuluna xuluna is a code owner

@KerryKovacevic KerryKovacevic Awaiting requested review from KerryKovacevic KerryKovacevic is a code owner

@MaksimDell MaksimDell Awaiting requested review from MaksimDell

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@Sahiba-Gupta Sahiba-Gupta Awaiting requested review from Sahiba-Gupta Sahiba-Gupta is a code owner

@jackieung-dell jackieung-dell Awaiting requested review from jackieung-dell jackieung-dell is a code owner

@rodrigobassil rodrigobassil Awaiting requested review from rodrigobassil

@anandrajak1 anandrajak1 Awaiting requested review from anandrajak1 anandrajak1 is a code owner

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chimanjain @csmbot @shaynafinocchiaro @alikdell @boyamurthy @HarishH-DELL