Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The NVMeCommand constant is insecure #26

Open
gk4delltech opened this issue Aug 24, 2023 · 0 comments
Open

The NVMeCommand constant is insecure #26

gk4delltech opened this issue Aug 24, 2023 · 0 comments

Comments

@gk4delltech
Copy link
Member

gk4delltech commented Aug 24, 2023

The NVMeCommand constant defined in gonvme_tcp_fc.go is insecure, because the path is not given. When the exec.Command runs then you are at the mercy of the PATH enviornment variable. It could be possible to set the PATH, add a mock "nvme" command, then execute gonvme which will execute the mock nvme. You must give the full path in the command constant to prevent this. This is a well known UNIX/Linux practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant