From 25e7bc254551edcb558a4267686e0b7d59c921bb Mon Sep 17 00:00:00 2001 From: Rohit Gohri Date: Tue, 8 Aug 2023 17:04:12 +0200 Subject: [PATCH] fix links --- .changeset/config.json | 2 +- CHANGELOG.md | 52 ++++++++++++------------ src/client/googlePubSub/subscriptions.ts | 2 +- 3 files changed, 28 insertions(+), 28 deletions(-) diff --git a/.changeset/config.json b/.changeset/config.json index 1344d7a0..862ece92 100644 --- a/.changeset/config.json +++ b/.changeset/config.json @@ -4,7 +4,7 @@ "../scripts/changesets/changelog.js", { "repo": "deliveryhero/hfc-pubsub", - "jiraUrl": "https://jira.deliveryhero.com/browse/atlassian.net" + "jiraUrl": "https://jira.deliveryhero.com" } ], "commit": true, diff --git a/CHANGELOG.md b/CHANGELOG.md index e0e709fe..ca7b04c8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,7 +14,7 @@ ### Patch Changes -- [PUB-88](https://jira.deliveryhero.com/browse/atlassian.net/browse/PUB-88) - Pin dependencies to specific versions ([#92](https://github.com/deliveryhero/hfc-pubsub/pull/92) by [@rohit-gohri](https://github.com/rohit-gohri)) +- [PUB-88](https://jira.deliveryhero.com/browse/PUB-88) - Pin dependencies to specific versions ([#92](https://github.com/deliveryhero/hfc-pubsub/pull/92) by [@rohit-gohri](https://github.com/rohit-gohri)) ## 2.1.1 @@ -26,13 +26,13 @@ ### Minor Changes -- [PUB-84](https://jira.deliveryhero.com/browse/atlassian.net/browse/PUB-84) - Add support for labels to subscirptions ([#88](https://github.com/deliveryhero/hfc-pubsub/pull/88) by [@rohit-gohri](https://github.com/rohit-gohri)) +- [PUB-84](https://jira.deliveryhero.com/browse/PUB-84) - Add support for labels to subscirptions ([#88](https://github.com/deliveryhero/hfc-pubsub/pull/88) by [@rohit-gohri](https://github.com/rohit-gohri)) ## 2.0.1 ### Patch Changes -- [PUB-72](https://jira.deliveryhero.com/browse/atlassian.net/browse/PUB-72) - Divide subscriptions among multiple clients ([#86](https://github.com/deliveryhero/hfc-pubsub/pull/86) by [@rohit-gohri](https://github.com/rohit-gohri)) +- [PUB-72](https://jira.deliveryhero.com/browse/PUB-72) - Divide subscriptions among multiple clients ([#86](https://github.com/deliveryhero/hfc-pubsub/pull/86) by [@rohit-gohri](https://github.com/rohit-gohri)) ## 2.0.0 @@ -40,13 +40,13 @@ ### ⚠️ Major Changes ⚠️ -- [PUB-68](https://jira.deliveryhero.com/browse/atlassian.net/browse/PUB-68) - Set min supported node version as 12.22 ([#72](https://github.com/deliveryhero/hfc-pubsub/pull/72) by [@rohit-gohri](https://github.com/rohit-gohri)) +- [PUB-68](https://jira.deliveryhero.com/browse/PUB-68) - Set min supported node version as 12.22 ([#72](https://github.com/deliveryhero/hfc-pubsub/pull/72) by [@rohit-gohri](https://github.com/rohit-gohri)) -- [PUB-52](https://jira.deliveryhero.com/browse/atlassian.net/browse/PUB-52) - Remove `grpc` ([#57](https://github.com/deliveryhero/hfc-pubsub/pull/57) by [@rohit-gohri](https://github.com/rohit-gohri)) +- [PUB-52](https://jira.deliveryhero.com/browse/PUB-52) - Remove `grpc` ([#57](https://github.com/deliveryhero/hfc-pubsub/pull/57) by [@rohit-gohri](https://github.com/rohit-gohri)) -- [PUB-48](https://jira.deliveryhero.com/browse/atlassian.net/browse/PUB-48) - Topic class now uses static properties and generics ([#81](https://github.com/deliveryhero/hfc-pubsub/pull/81) by [@rohit-gohri](https://github.com/rohit-gohri)) +- [PUB-48](https://jira.deliveryhero.com/browse/PUB-48) - Topic class now uses static properties and generics ([#81](https://github.com/deliveryhero/hfc-pubsub/pull/81) by [@rohit-gohri](https://github.com/rohit-gohri)) -- [PUB-77](https://jira.deliveryhero.com/browse/atlassian.net/browse/PUB-77) - Misc Changes ([#84](https://github.com/deliveryhero/hfc-pubsub/pull/84) by [@rohit-gohri](https://github.com/rohit-gohri)) +- [PUB-77](https://jira.deliveryhero.com/browse/PUB-77) - Misc Changes ([#84](https://github.com/deliveryhero/hfc-pubsub/pull/84) by [@rohit-gohri](https://github.com/rohit-gohri)) - Change project-id env var to `GOOGLE_CLOUD_PROJECT` - Removed export of private methods @@ -54,11 +54,11 @@ - Change `ackDeadlineSeconds` to `ackDeadline` - Add `metadata` to default error handler -- [PUB-65](https://jira.deliveryhero.com/browse/atlassian.net/browse/PUB-65) - Remove deprecated code ([#66](https://github.com/deliveryhero/hfc-pubsub/pull/66) by [@rohit-gohri](https://github.com/rohit-gohri)) +- [PUB-65](https://jira.deliveryhero.com/browse/PUB-65) - Remove deprecated code ([#66](https://github.com/deliveryhero/hfc-pubsub/pull/66) by [@rohit-gohri](https://github.com/rohit-gohri)) ### Minor Changes -- [PUB-73](https://jira.deliveryhero.com/browse/atlassian.net/browse/PUB-73) - Add/improve helpers and TS usage([#79](https://github.com/deliveryhero/hfc-pubsub/pull/79) by [@ishan123456789](https://github.com/ishan123456789)) +- [PUB-73](https://jira.deliveryhero.com/browse/PUB-73) - Add/improve helpers and TS usage([#79](https://github.com/deliveryhero/hfc-pubsub/pull/79) by [@ishan123456789](https://github.com/ishan123456789)) 1. Allows to make `_timestamp` optional 2. Removes double validation of topic names. @@ -66,13 +66,13 @@ 4. Adds `.toJSON` method to get parsed message/ 5. Remove getters (like getProjects, getName, getClient) and just use `this.projects`, `this.name`, etc directly. -- [PUB-69](https://jira.deliveryhero.com/browse/atlassian.net/browse/PUB-69) - Changed init position for `SubscriptionService.instance` ([#77](https://github.com/deliveryhero/hfc-pubsub/pull/77) by [@ishan123456789](https://github.com/ishan123456789)) +- [PUB-69](https://jira.deliveryhero.com/browse/PUB-69) - Changed init position for `SubscriptionService.instance` ([#77](https://github.com/deliveryhero/hfc-pubsub/pull/77) by [@ishan123456789](https://github.com/ishan123456789)) ### Patch Changes -- [PUB-75](https://jira.deliveryhero.com/browse/atlassian.net/browse/PUB-75) - Using yarn instead of npm ([#83](https://github.com/deliveryhero/hfc-pubsub/pull/83) by [@ishan123456789](https://github.com/ishan123456789)) +- [PUB-75](https://jira.deliveryhero.com/browse/PUB-75) - Using yarn instead of npm ([#83](https://github.com/deliveryhero/hfc-pubsub/pull/83) by [@ishan123456789](https://github.com/ishan123456789)) -- [PUB-69](https://jira.deliveryhero.com/browse/atlassian.net/browse/PUB-69) - Throws error in case no subs found or wrong `PUBSUB_ROOT_DIR` env defined ([#76](https://github.com/deliveryhero/hfc-pubsub/pull/76) by [@ishan123456789](https://github.com/ishan123456789)) +- [PUB-69](https://jira.deliveryhero.com/browse/PUB-69) - Throws error in case no subs found or wrong `PUBSUB_ROOT_DIR` env defined ([#76](https://github.com/deliveryhero/hfc-pubsub/pull/76) by [@ishan123456789](https://github.com/ishan123456789)) **Full Changelog: [v1.11.0...v2.0.0](https://github.com/deliveryhero/hfc-pubsub/compare/v1.11.0...v2.0.0)** @@ -82,29 +82,29 @@ - Adds optional health check server to tell if all subs are open or not ([#73](https://github.com/deliveryhero/hfc-pubsub/pull/73) by [@ishan123456789](https://github.com/ishan123456789)) -- [PUB-71](https://jira.deliveryhero.com/browse/atlassian.net/browse/PUB-71) - Add Subscription level handleError method ([#75](https://github.com/deliveryhero/hfc-pubsub/pull/75) by [@ketan-saxena](https://github.com/ketan-saxena)) +- [PUB-71](https://jira.deliveryhero.com/browse/PUB-71) - Add Subscription level handleError method ([#75](https://github.com/deliveryhero/hfc-pubsub/pull/75) by [@ketan-saxena](https://github.com/ketan-saxena)) ### Patch Changes -- [PUB-64](https://jira.deliveryhero.com/browse/atlassian.net/browse/PUB-64) - Update dependencies ([#78](https://github.com/deliveryhero/hfc-pubsub/pull/78) by [@rohit-gohri](https://github.com/rohit-gohri)) +- [PUB-64](https://jira.deliveryhero.com/browse/PUB-64) - Update dependencies ([#78](https://github.com/deliveryhero/hfc-pubsub/pull/78) by [@rohit-gohri](https://github.com/rohit-gohri)) ## 1.10.4 ### Patch Changes -- [PUB-60](https://jira.deliveryhero.com/browse/atlassian.net/browse/PUB-60) - Deprecate v1,v2 style Subscriber classes ([#64](https://github.com/deliveryhero/hfc-pubsub/pull/64) by [@rohit-gohri](https://github.com/rohit-gohri)) +- [PUB-60](https://jira.deliveryhero.com/browse/PUB-60) - Deprecate v1,v2 style Subscriber classes ([#64](https://github.com/deliveryhero/hfc-pubsub/pull/64) by [@rohit-gohri](https://github.com/rohit-gohri)) -- [PUB-66](https://jira.deliveryhero.com/browse/atlassian.net/browse/PUB-66) - Fix close method creating new subscription instance rather than closing existing one ([#63](https://github.com/deliveryhero/hfc-pubsub/pull/63) by [@rohit-gohri](https://github.com/rohit-gohri)) +- [PUB-66](https://jira.deliveryhero.com/browse/PUB-66) - Fix close method creating new subscription instance rather than closing existing one ([#63](https://github.com/deliveryhero/hfc-pubsub/pull/63) by [@rohit-gohri](https://github.com/rohit-gohri)) ## 1.10.3 ### Patch Changes -- [PUB-52](https://jira.deliveryhero.com/browse/atlassian.net/browse/PUB-52) - Deprecate native grpc usage ([#58](https://github.com/deliveryhero/hfc-pubsub/pull/58) by [@rohit-gohri](https://github.com/rohit-gohri)) +- [PUB-52](https://jira.deliveryhero.com/browse/PUB-52) - Deprecate native grpc usage ([#58](https://github.com/deliveryhero/hfc-pubsub/pull/58) by [@rohit-gohri](https://github.com/rohit-gohri)) - Allows setting up env variables through CLI args ([#61](https://github.com/deliveryhero/hfc-pubsub/pull/61) by [@ishan123456789](https://github.com/ishan123456789)) -- [PUB-50](https://jira.deliveryhero.com/browse/atlassian.net/browse/PUB-50) - Update documentation ([#60](https://github.com/deliveryhero/hfc-pubsub/pull/60) by [@rohit-gohri](https://github.com/rohit-gohri)) +- [PUB-50](https://jira.deliveryhero.com/browse/PUB-50) - Update documentation ([#60](https://github.com/deliveryhero/hfc-pubsub/pull/60) by [@rohit-gohri](https://github.com/rohit-gohri)) ## 1.10.2 @@ -124,35 +124,35 @@ ### Minor Changes -- [PUB-44](https://jira.deliveryhero.com/browse/atlassian.net/browse/PUB-44) - Added option to add custom logger ([#45](https://github.com/deliveryhero/hfc-pubsub/pull/45) by [@ishan123456789](https://github.com/ishan123456789)) +- [PUB-44](https://jira.deliveryhero.com/browse/PUB-44) - Added option to add custom logger ([#45](https://github.com/deliveryhero/hfc-pubsub/pull/45) by [@ishan123456789](https://github.com/ishan123456789)) ### Patch Changes -- [PUB-44](https://jira.deliveryhero.com/browse/atlassian.net/browse/PUB-44) - Add changesets to manage versioning ([#44](https://github.com/deliveryhero/hfc-pubsub/pull/44) by [@rohit-gohri](https://github.com/rohit-gohri)) +- [PUB-44](https://jira.deliveryhero.com/browse/PUB-44) - Add changesets to manage versioning ([#44](https://github.com/deliveryhero/hfc-pubsub/pull/44) by [@rohit-gohri](https://github.com/rohit-gohri)) ## 1.9.0 ### Minor Changes -- [PUB-47](https://jira.deliveryhero.com/browse/atlassian.net/browse/PUB-47) - Optimized DLQ configuration making PROJECT_NUMBER optional for assigning Publisher, Subscriber roles and allowing default subscription creation as a part of DLQ configuration ([#43](https://github.com/deliveryhero/hfc-pubsub/pull/43) by [@ishan123456789](https://github.com/ishan123456789)) +- [PUB-47](https://jira.deliveryhero.com/browse/PUB-47) - Optimized DLQ configuration making PROJECT_NUMBER optional for assigning Publisher, Subscriber roles and allowing default subscription creation as a part of DLQ configuration ([#43](https://github.com/deliveryhero/hfc-pubsub/pull/43) by [@ishan123456789](https://github.com/ishan123456789)) ## 1.8.1 ### Patch Changes -- [PUB-46](https://jira.deliveryhero.com/browse/atlassian.net/browse/PUB-46) - Allow multiple entry points without checking for folder ([#42](https://github.com/deliveryhero/hfc-pubsub/pull/42) by [@rohit-gohri](https://github.com/rohit-gohri)) +- [PUB-46](https://jira.deliveryhero.com/browse/PUB-46) - Allow multiple entry points without checking for folder ([#42](https://github.com/deliveryhero/hfc-pubsub/pull/42) by [@rohit-gohri](https://github.com/rohit-gohri)) ## 1.8.0 ### Minor Changes -- [PUB-42](https://jira.deliveryhero.com/browse/atlassian.net/browse/PUB-42) - Add attributes option to publish command in Topic ([#41](https://github.com/deliveryhero/hfc-pubsub/pull/41) by [@rohit-gohri](https://github.com/rohit-gohri)) +- [PUB-42](https://jira.deliveryhero.com/browse/PUB-42) - Add attributes option to publish command in Topic ([#41](https://github.com/deliveryhero/hfc-pubsub/pull/41) by [@rohit-gohri](https://github.com/rohit-gohri)) ### Patch Changes -- [PUB-34](https://jira.deliveryhero.com/browse/atlassian.net/browse/PUB-34) - Update subscriber metadata for existing subscriptions ([#32](https://github.com/deliveryhero/hfc-pubsub/pull/32) by [@ishan123456789](https://github.com/ishan123456789)) +- [PUB-34](https://jira.deliveryhero.com/browse/PUB-34) - Update subscriber metadata for existing subscriptions ([#32](https://github.com/deliveryhero/hfc-pubsub/pull/32) by [@ishan123456789](https://github.com/ishan123456789)) -- [PUB-43](https://jira.deliveryhero.com/browse/atlassian.net/browse/PUB-43) - Attach subscriber metadata to error object in case unable to start subscription ([#39](https://github.com/deliveryhero/hfc-pubsub/pull/39) by [@rohit-gohri](https://github.com/rohit-gohri)) +- [PUB-43](https://jira.deliveryhero.com/browse/PUB-43) - Attach subscriber metadata to error object in case unable to start subscription ([#39](https://github.com/deliveryhero/hfc-pubsub/pull/39) by [@rohit-gohri](https://github.com/rohit-gohri)) ## 1.7.12 @@ -160,4 +160,4 @@ - Fix build due to invalid import paths ([#38](https://github.com/deliveryhero/hfc-pubsub/pull/38) by [@rohit-gohri](https://github.com/rohit-gohri)) -- [PUB-31](https://jira.deliveryhero.com/browse/atlassian.net/browse/PUB-31) - Add close method for graceful shutdowns ([#20](https://github.com/deliveryhero/hfc-pubsub/pull/20) by [@rohit-gohri](https://github.com/rohit-gohri)) +- [PUB-31](https://jira.deliveryhero.com/browse/PUB-31) - Add close method for graceful shutdowns ([#20](https://github.com/deliveryhero/hfc-pubsub/pull/20) by [@rohit-gohri](https://github.com/rohit-gohri)) diff --git a/src/client/googlePubSub/subscriptions.ts b/src/client/googlePubSub/subscriptions.ts index 15a61a93..04b2bc31 100644 --- a/src/client/googlePubSub/subscriptions.ts +++ b/src/client/googlePubSub/subscriptions.ts @@ -17,7 +17,7 @@ export function getSubscription( // eslint-disable-next-line @typescript-eslint/no-non-null-assertion return subscriptions.get(metadata.subscriptionName)!; } - // NOTE: Each client can handle a max of 20 subs, but limiting to 15 https://jira.deliveryhero.com/browse/atlassian.net/browse/PUB-72 + // NOTE: Each client can handle a max of 20 subs, but limiting to 15 https://jira.deliveryhero.com/browse/PUB-72 const isNewClientNeeded = Math.floor(subscriptions.size / 15) > _clients.length - 1;