New contact fields handling

[kolinko-ant]

Hi!

Thanks for you library, it's helpful.

I have an error right now type "array" is not a valid autopilot data type (AutopilotField.php line 311), because of new array fields coming in autopilot response, i.e.:

• mail_received
• mail_opened
• anywhere_page_visits
• anywhere_utm .

Is there a chance to fix it and handle these new fields? Or you don't maintain anymore this library?

Thanks in advance.

[nicolasThal]

Hi,

We are still using this library on our live website.

I haven't saw any kind of error lately, but I will look a little bit through it.

If you have an idea for a fix, I will be more than pleased to review and accept it !

Thanks for your help !

[kolinko-ant]

I think, such fields are optional and may present or not in your contact response, it depends on what input data comes to autopilot.

To fix it, it's good to understand why do you restrict array type for the field?

[kolinko-ant]

Oh, i see in doc - because of custom fields probaby

[kolinko-ant]

As a fix I suggest to detect such fields by checking that it's not $reservedFields and it's not $casts field. If so, put such fields to some array like unchangableFields and then just send them as to saveContact method.

Or another idea - just extend $casts array with such fields.

You know better, what fix will be the most correct. What do you think?

[kolinko-ant]

@nicolasThal
Here is the implementation of the last idea - #9

[nicolasThal]

@kolinko-ant, As I am not the creator of the lib, I need some time to see the changes implicated by your modification.

I am also looking for a test case that can break the existing code, in order to validate your modification.

What does the autopilot response looks like with the array fields ?

[kolinko-ant]

What does the autopilot response looks like with the array fields ?

http://take.ms/fv1tE

[nicolasThal]

Thank you for the dataset !

I tried to add it to the test case that are already created but without any success.
So I have two questions :

• does the fix Save unknown contact fields as readonly #9 works for you ? If yes, I could create a new release with it
• Have you tried to avoid setting AutopilotFields whenever the value is an array here https://github.com/dekalee/php-autopilothq/blob/master/src/AutopilotContact.php#L171 ?

[kolinko-ant]

@nicolasThal

I tried to add it to the test case that are already created

could you point me to this test case?

[nicolasThal]

The test are located in this file : https://github.com/dekalee/php-autopilothq/blob/master/tests/unit/AutopilotFieldCest.php#L128

To run it, you could launch the command : ./vendor/bin/codecept run after a composer install.

I have added a small commit to the master branch to avoid some php warning, you could rebase your branch to have it.

[kolinko-ant]

I will take a look to it. Thanks

[nicolasThal]

Hi @kolinko-ant ,

How are you progressing with the test case ?

Did do you do other modifications to make the code work ?

[nicolasThal]

Hi @kolinko-ant

I wish you a happy new year.

How are you progressing with the test case ?

[nicolasThal]

Hi @kolinko-ant,

I am still ok to merge your pr in the main code to avoid package duplication.

Did you look throught the test writting ?