Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement "firstSeen" and "lastSeen" cluster properties #115

Open
jackfrancis opened this issue May 4, 2016 · 0 comments
Open

implement "firstSeen" and "lastSeen" cluster properties #115

jackfrancis opened this issue May 4, 2016 · 0 comments
Assignees
Labels

Comments

@jackfrancis
Copy link
Member

jackfrancis commented May 4, 2016

There are really two issues:

  • we're not doing anything useful with the existing "firstSeen" and "lastSeen" properties (the properties are inheriting their zero value, documented here: https://golang.org/pkg/time/#Time)
  • we're polluting the data properties in the cluster db record

A proposal: get rid of these two properties in the Cluster types we're using to submit to the database (or use another type definition); and then add these metadata in a meaningful way using a different type struct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants