Added support for building C/C++ libraries via bob #326
+63
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCash
commented
Nov 22, 2023
| @@ -976,14 +976,12 @@ public boolean accept(File pathname) { | |||
| return outputFiles; | |||
| } | |||
|
|
|||
| private void buildExtension(File manifest, Map<String, Object> manifestContext) throws IOException, InterruptedException, ExtenderException { | |||
| private List<File> buildExtensionInternal(File manifest, Map<String, Object> manifestContext, List<File> srcDirs, File libraryOut) throws IOException, InterruptedException, ExtenderException { | |||
There was a problem hiding this comment.
Mostly same as before, but can override the output library file
| LOGGER.info("buildLibrary"); | ||
| List<File> srcDirs = new ArrayList<>(); | ||
| srcDirs.add(uploadDirectory); | ||
| String libName = String.format(platformConfig.writeLibPattern, manifestContext.get("extension_name")); |
There was a problem hiding this comment.
Making it easy to control the library name from bob
| return shouldBuildArtifact("library"); | ||
| } | ||
|
|
||
| private List<File> buildLibraries() throws ExtenderException { |
There was a problem hiding this comment.
This is a shortened copy of buildEngine() without the linker step.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.