Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(conda): update conda file #2227

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

njzjz
Copy link
Member

@njzjz njzjz commented May 10, 2024

Summary by CodeRabbit

  • New Features
    • Updated build requirements to include cmake >=3.26 and make for Unix systems.
  • Refactor
    • Switched to scikit-build-core >=0.9.0 for host requirements.
    • Simplified Python requirement to python in runtime dependencies.
    • Replaced matplotlib with matplotlib-base in runtime dependencies for efficiency.

@njzjz njzjz enabled auto-merge May 10, 2024 06:43
Copy link
Contributor

coderabbitai bot commented May 10, 2024

Walkthrough

Walkthrough

The recent modifications to the package configuration involve refining build and host requirements, specifically upgrading to newer tool versions and optimizing dependency management. Changes include specifying newer versions of build tools like cmake and replacing certain dependencies with more appropriate alternatives for better performance and compatibility.

Changes

File Path Change Summary
conda/recipe/meta.yaml - Updated build tools to cmake >=3.26 and make.
- Switched setuptools >=61 to scikit-build-core >=0.9.0 in host requirements.
- Simplified python requirement in run requirements.
- Substituted matplotlib with matplotlib-base.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between c2f435a and 448f32b.
Files selected for processing (1)
  • conda/recipe/meta.yaml (1 hunks)
Additional comments not posted (3)
conda/recipe/meta.yaml (3)

21-22: The addition of cmake >=3.26 and conditional make for Unix environments are appropriate for ensuring the build process is robust across different platforms.


29-29: Transitioning to scikit-build-core >=0.9.0 aligns well with the use of cmake, facilitating better integration between Python and C/C++ components.


32-32: Simplifying the Python version requirement increases compatibility but ensure testing across the versions you intend to support. Replacing matplotlib with matplotlib-base is a good practice to reduce unnecessary dependencies in non-GUI environments.

Also applies to: 38-38


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.23%. Comparing base (c2f435a) to head (448f32b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2227   +/-   ##
=======================================
  Coverage   95.23%   95.23%           
=======================================
  Files          18       18           
  Lines        1448     1448           
=======================================
  Hits         1379     1379           
  Misses         69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 10, 2024

CodSpeed Performance Report

Merging #2227 will not alter performance

Comparing njzjz:update-conda-file (448f32b) with master (c2f435a)

Summary

✅ 8 untouched benchmarks

@njzjz njzjz added this pull request to the merge queue May 10, 2024
Merged via the queue into deepmodeling:master with commit e5e98e1 May 10, 2024
22 checks passed
@njzjz njzjz deleted the update-conda-file branch May 10, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant