-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fail to run task if remote_root path doesn't existed #436
Comments
This seems to be an unsafe behavior, when one gives a wrong path. Considering one only needs to create a directory once, but needs to ensure the path is correct in each submission, I prefer throwing the error when the directory does not exist. |
It's always possible for users to choose a wrong path whether you create path for them or not. It just make users feel less convenient than improve security. The reason I think root path should be created automatically is I will choose different remote directories for different projects and different runs. I don't want to login to a remote session just for creating a path. Besides of it, for workflows that are running across diffferent clusters it would be annoy to create the path manually on each of them. |
This doesn't make sense. The submission runs in a temporary subdirectory of the root path instead of the root path itself, which will be entirely deleted after the submission is finished. The hash of the submission determines the subdirectory name, so the subdirectory will be different once any of the commands, the forward/backward file paths, or the local root is different.
This is more dangerous, considering different machines may have different directory structures. If you don't log in to the cluster to check whether the directory exists, you may create directories in the wrong path. |
I am aware of it. Then how about provide an option to enable this behavior? |
When I running the following code with dflow
If the
remote_root
path doesn't existed, it will raise error instead of create it automatically. I think this could be easily fixed by usingmkdir -p
oros.makedirs(path, exist_ok=True)
somewhere in dpdispatcher.The text was updated successfully, but these errors were encountered: