Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new format : qe/pw/md #472

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from
Open

Conversation

pee8379
Copy link
Contributor

@pee8379 pee8379 commented May 18, 2023

allow dpdata accept several new calculation modes of quantum espresso pw; md, vc-md, relax, vc-relax,

new format key 'qe/pw/md' is used.

many of codes are derived from original scf.py file.

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 13.25% and project coverage change: -1.94 ⚠️

Comparison is base (85a3b5e) 82.76% compared to head (75ffbf7) 80.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #472      +/-   ##
==========================================
- Coverage   82.76%   80.82%   -1.94%     
==========================================
  Files          70       71       +1     
  Lines        6313     6494     +181     
==========================================
+ Hits         5225     5249      +24     
- Misses       1088     1245     +157     
Impacted Files Coverage Δ
dpdata/qe/pwmd.py 11.04% <11.04%> (ø)
dpdata/plugins/qe.py 88.23% <55.55%> (-11.77%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@wanghan-iapcm wanghan-iapcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add unittests for your PR? Thank you.

@njzjz njzjz changed the base branch from master to devel July 7, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants