Fix: fix a bug in diago_elpa_native.cpp #5155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The solution is correct. Both elpa and cusolvermp require the same amount of memory as input. |
goodchong
approved these changes
Sep 23, 2024
mohanchen
approved these changes
Sep 24, 2024
mohanchen
added
the
Bugs (Exclude input and output)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Under multi-k situation, the size of
psiandeigenvectorsare different. Directly assigning the eigenvectors solved byelpa_generalized_eigenvectorstopsiwill lead to array out-of-bounds errors. The cusolvermp related code has the same problem, which is also fixed in this PR.