Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: remove useless warning for dp #5153

Merged
merged 4 commits into from
Sep 21, 2024
Merged

Refactor: remove useless warning for dp #5153

merged 4 commits into from
Sep 21, 2024

Conversation

YuLiu98
Copy link
Collaborator

@YuLiu98 YuLiu98 commented Sep 21, 2024

Linked Issue

Fix #5106

Unit Tests and/or Case Tests for my changes

  • A unit test is added for output_after_relax()

What's changed?

  • remove useless relax warning for dp/lj
  • remove useless delete_tmp_file()

@mohanchen mohanchen removed the request for review from hongriTianqi September 21, 2024 07:44
@mohanchen mohanchen merged commit 7c8a4da into deepmodeling:develop Sep 21, 2024
14 checks passed
@mohanchen mohanchen added the The Absolute Zero Reduce the "entropy" of the code to 0 label Sep 21, 2024
@YuLiu98 YuLiu98 deleted the dp branch September 21, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanchen mohanchen mohanchen approved these changes

Assignees
No one assigned
Labels
The Absolute Zero Reduce the "entropy" of the code to 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unnecessary screen output when running ABACUS with dp
2 participants
@YuLiu98 @mohanchen