Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: consistent order of hpsi #5134

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

Cstandardlib
Copy link
Collaborator

Linked Issue

Fix #5133

What's changed?

  • Change the order of [in/out] parameter of hpsi_func used by dav and dav_subspace to be consistent with others.

@mohanchen mohanchen merged commit c4a324d into deepmodeling:develop Sep 20, 2024
14 checks passed
@mohanchen mohanchen added the The Absolute Zero Reduce the "entropy" of the code to 0 label Sep 20, 2024
@Cstandardlib Cstandardlib deleted the unify-param-order branch September 20, 2024 15:34
a1henu added a commit to a1henu/abacus-develop that referenced this pull request Sep 26, 2024
mohanchen pushed a commit that referenced this pull request Sep 26, 2024
…ignature in `hpsi_func` (#5176)

* fix some typos in `_hsolver.py`

* fix some bugs caused by #5134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
The Absolute Zero Reduce the "entropy" of the code to 0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent interface of hpsi and spsi
2 participants