Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Modify class BaseMatrix #4239

Merged
merged 39 commits into from
May 27, 2024
Merged

Refactor: Modify class BaseMatrix #4239

merged 39 commits into from
May 27, 2024

Conversation

DylanWRh
Copy link

@DylanWRh DylanWRh commented May 26, 2024 •
edited
Loading

Reminder

  • Have you explained the changes of codes in core modules of ESolver, HSolver, ElecState, Hamilt, Operator or Psi? (ignore if not applicable)

What's changed?

Refactor the code in class BaseMatrix to be safer.

  • Add allocation judgement and possible memory release in operator= to avoid potential memory waste
  • Add debug statement to check if value_begin is nullptr in functions such as add_array, add_element, and get_value.
  • Modify documentation for add_array function to avoid potential misunserstanding

DylanWRh and others added 30 commits March 29, 2024 15:57
@DylanWRh
initialize some variables
84e685c
@DylanWRh
fix a semicolon
e7e0c3c
@DylanWRh
Merge branch 'develop' into develop
d7b6d50
@DylanWRh
Merge branch 'develop' into develop
97ef279
@DylanWRh
Merge branch 'develop' into develop
fa37082
@DylanWRh
Update sincos.cpp
c51b87d
@DylanWRh
Update mathzone_add1.cpp
3eb45c2
@DylanWRh
Update mathzone_add1.cpp
84e3da6
@DylanWRh
Update opt_DCsrch.cpp
0346eb8
@DylanWRh
Update broyden_mixing.cpp
0b060ad
@DylanWRh
Update pulay_mixing.cpp
0d2eb24
@DylanWRh
Update math_sphbes_test.cpp
bba21b6
@DylanWRh
Update ORB_gen_tables.cpp
263a85f
@DylanWRh
Update ORB_table_phi.cpp
7019e68
@DylanWRh
Merge branch 'develop' into develop
5410464
@DylanWRh
Update math_sphbes_test.cpp
3930ce5
@DylanWRh
Merge branch 'deepmodeling:develop' into develop
6ce77ac
@DylanWRh
Change some pointers to vectors
47c7330
@DylanWRh
Update formatter_contextfmt_test.cpp
35920dd
@DylanWRh
Change pointers to vectors
c141f54
@DylanWRh
Change pointers to vectors
e572d51
@DylanWRh
Rollback
c688532
@DylanWRh
Replace some pointers with vectors
4d6c7c7
@DylanWRh
Merge branch 'develop' into develop
967b598
@DylanWRh
Change some pointers to vectors
fbf048d
@DylanWRh
Merge branch 'develop' of https://github.com/DylanWRh/abacus-develop …
6380de0 
…into develop
@DylanWRh
Merge branch 'develop' into develop
def4d84
@DylanWRh
Merge branch 'deepmodeling:develop' into develop
a7a4b38
@DylanWRh
Merge branch 'deepmodeling:develop' into develop
73eabdd
@DylanWRh
Merge branch 'deepmodeling:develop' into develop
0d73194
@DylanWRh DylanWRh marked this pull request as ready for review May 26, 2024 13:29
@mohanchen mohanchen requested a review from dyzheng May 27, 2024 01:04
dyzheng
dyzheng approved these changes May 27, 2024
View reviewed changes
Copy link
Collaborator

@dyzheng dyzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dyzheng dyzheng merged commit 79b9111 into deepmodeling:develop May 27, 2024
13 checks passed
@dyzheng
Copy link
Collaborator

dyzheng commented May 27, 2024

@DylanWRh please simplify your commit history

1 similar comment
@dyzheng
Copy link
Collaborator

dyzheng commented May 27, 2024

@DylanWRh please simplify your commit history

@DylanWRh
Copy link
Author

@DylanWRh please simplify your commit history

OK! I'll pay attention to that in future PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dyzheng dyzheng dyzheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DylanWRh @dyzheng