Refactor: modify arguments of gemm and gemv #4238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First of all, thank you very much for your contribution and PR. I noticed that this way of writing uses a feature of C++20 called designated initializers. Since using an overly advanced version of syntax features will lead to reduced software compatibility, ABACUS currently does not plan to introduce syntax features after C++11. So, thank you very much for your PR, but unfortunately such modifications cannot be merged into the main branch at present. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some function calls(especially those calling LAPACK functions) have extremely long list of arguments, impairing readability and improves the risk of writing the wrong code. Therefore, structs are used to pass arguments for better readability.