Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: remove all globalV in diago_david #4211

Merged
merged 22 commits into from
May 27, 2024
Merged

Refactor: remove all globalV in diago_david #4211

merged 22 commits into from
May 27, 2024

Conversation

haozhihan
Copy link
Collaborator

Reminder

  • Have you linked an issue with this pull request?

Linked Issue

#4181

@mohanchen mohanchen self-requested a review May 24, 2024 01:27
@mohanchen mohanchen added the The Absolute Zero Reduce the "entropy" of the code to 0 label May 24, 2024
@haozhihan haozhihan marked this pull request as ready for review May 25, 2024 09:27
mohanchen
mohanchen reviewed May 26, 2024
View reviewed changes
source/module_hsolver/diagh.h Outdated Show resolved Hide resolved
source/module_hsolver/diagh.h Show resolved Hide resolved
source/module_hsolver/diago_david.cpp Outdated Show resolved Hide resolved
source/module_hsolver/diago_david.cpp Outdated Show resolved Hide resolved
source/module_hsolver/diago_david.cpp Outdated Show resolved Hide resolved
source/module_hsolver/hsolver_pw.cpp Outdated Show resolved Hide resolved
source/module_hsolver/test/diago_david_float_test.cpp Outdated Show resolved Hide resolved
@mohanchen mohanchen merged commit f7ac628 into deepmodeling:develop May 27, 2024
13 checks passed
@haozhihan haozhihan deleted the Refactor/hsolver_remove_globalV branch June 14, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanchen mohanchen mohanchen approved these changes

Assignees
No one assigned
Labels
The Absolute Zero Reduce the "entropy" of the code to 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haozhihan @mohanchen