Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyabacus::hsolver failed due to changes of the order of [in\out] parameters in hpsi_func #5175

Closed
2 of 16 tasks
a1henu opened this issue Sep 26, 2024 · 0 comments · Fixed by #5176
Closed
2 of 16 tasks

Comments

@a1henu
Copy link
Collaborator

a1henu commented Sep 26, 2024

Describe the bug

Issue #5133 describes a code quality issue: "Inconsistent interface of hpsi and spsi". Pull request #5134 changes the order of the [in/out] parameters of hpsi_func.

However, this change will affect the code in pyabacus::hsolver and cause bugs, leading to unit test failures.

Expected behavior

No response

To Reproduce

No response

Environment

No response

Additional Context

No response

Task list for Issue attackers (only for developers)

  • Verify the issue is not a duplicate.
  • Describe the bug.
  • Steps to reproduce.
  • Expected behavior.
  • Error message.
  • Environment details.
  • Additional context.
  • Assign a priority level (low, medium, high, urgent).
  • Assign the issue to a team member.
  • Label the issue with relevant tags.
  • Identify possible related issues.
  • Create a unit test or automated test to reproduce the bug (if applicable).
  • Fix the bug.
  • Test the fix.
  • Update documentation (if necessary).
  • Close the issue and inform the reporter (if applicable).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant