Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add JPMS/module-info data to this project #3473

Open
Siedlerchr opened this issue Sep 15, 2024 · 2 comments
Open

Please add JPMS/module-info data to this project #3473

Siedlerchr opened this issue Sep 15, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@Siedlerchr
Copy link

Description

For better usage in a modularized application and to prevent hacky workarounds, it would be great to provide the correct module info declaration. Especially for the ServiceProviders.
Refs JabRef/jabref#11761

https://www.oracle.com/corporate/features/understanding-java-9-modules.html

Will this change the current api? How?

No

Who will benefit from this enhancement?

Consumers of the libary e.g. JabRef
JabRef/jabref#11761

References

Langchain: langchain4j/langchain4j#1066
https://www.oracle.com/corporate/features/understanding-java-9-modules.html
https://javanexus.com/blog/solving-puzzle-java-9-module-system-challenges
https://www.baeldung.com/java-modularity

@Siedlerchr Siedlerchr added the enhancement New feature or request label Sep 15, 2024
@frankfliu
Copy link
Contributor

@Siedlerchr

We already support auto-module in DJL. Here is example: https://github.com/deepjavalibrary/djl-demo/tree/master/development/module

@Siedlerchr
Copy link
Author

Siedlerchr commented Sep 15, 2024

Yes, that's a good thing but explicit module would be better, especially regarding the zoo service provider.
You need to add a provides clause see https://github.com/JabRef/jabref/pull/11761/files for what we needed to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants