fix: number field format options #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofojed
requested changes
Sep 13, 2024
There was a problem hiding this comment.
Weird, I could have sworn this wasn't working but indeed you can input a decimal. I should have included more details in the issue when I filed it.
In any case, we should still add these formatting options, to explicitly show the decimal, or to restrict to only an integer, etc.
mofojed
requested changes
Sep 26, 2024
ethanalvizo
requested review from
a team and
jnumainville
and removed request for
a team
jnumainville
requested changes
Oct 11, 2024
plugins/ui/src/deephaven/ui/components/types/Intl/number_field.py
Outdated
Show resolved
Hide resolved
ethanalvizo
changed the title
Merged
jnumainville
approved these changes
Oct 11, 2024
mofojed
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #695