Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: flex #785

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

docs: flex #785

wants to merge 10 commits into from
+382 −5

Conversation

ethanalvizo
Copy link
Contributor

@ethanalvizo ethanalvizo commented Aug 29, 2024 •
edited
Loading

Closes #688
Closes #824

@ethanalvizo ethanalvizo self-assigned this Aug 29, 2024
margaretkennedy
margaretkennedy reviewed Sep 3, 2024
View reviewed changes
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
dsmmcken
dsmmcken requested changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@dsmmcken dsmmcken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some of these examples cause bad overflow, which isn't your fault but they still look bad. I am down a rabbit hole on seeing if there's a global fix.

plugins/ui/docs/README.md Show resolved Hide resolved
plugins/ui/docs/components/flex.md Outdated Show resolved Hide resolved
@mofojed mofojed mentioned this pull request Sep 23, 2024
Closed
@mofojed mofojed linked an issue Sep 23, 2024 that may be closed by this pull request
ui.flex is missing many props now #902
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@margaretkennedy margaretkennedy margaretkennedy left review comments

@dsmmcken dsmmcken Awaiting requested review from dsmmcken

Requested changes must be addressed to merge this pull request.

Assignees

@ethanalvizo ethanalvizo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ui.flex is missing common props doc strings docs: ui.flex ui.flex is missing many props now
3 participants
@ethanalvizo @dsmmcken @margaretkennedy