Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize JsPlugin #15

Closed
devinrsmith opened this issue Dec 8, 2023 · 0 comments · Fixed by #16
Closed

Finalize JsPlugin #15

devinrsmith opened this issue Dec 8, 2023 · 0 comments · Fixed by #16
Assignees
@devinrsmith
Labels
enhancement New feature or request

Comments

@devinrsmith
Copy link
Member

JsPlugin was never used actually used server side. With this feature being re-prioritized, we'll probably want to take this opportunity to re-review and update JsPlugin as appropriate.

See deephaven/deephaven-core#4925
See deephaven/deephaven-plugins#150
@devinrsmith devinrsmith added the enhancement New feature or request label Dec 8, 2023
@devinrsmith devinrsmith self-assigned this Dec 8, 2023
@devinrsmith devinrsmith mentioned this issue Dec 9, 2023
Merged
devinrsmith added a commit to devinrsmith/deephaven-plugin that referenced this issue Dec 11, 2023
@devinrsmith
Updates JsPlugin distribution_path to root
59219ab 
In addition, updates JsPlugin documentation to be consistent with deephaven/deephaven-core#4925

Fixes deephaven#15
@devinrsmith devinrsmith mentioned this issue Dec 11, 2023
Merged
devinrsmith added a commit that referenced this issue Dec 13, 2023
@devinrsmith
Update JsPlugin for proper server-side support (#16)
1aed15b 
In addition, updates JsPlugin documentation to be more consistent with deephaven/deephaven-core#4925

Fixes #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devinrsmith devinrsmith

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update JsPlugin for proper server-side support devinrsmith/deephaven-plugin
1 participant
@devinrsmith