Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make column_to_numpy_array private #5256

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Make column_to_numpy_array private #5256

merged 2 commits into from
Mar 15, 2024

Conversation

jmao-denver
Copy link
Contributor

Fixes #5255

@jmao-denver jmao-denver added this to the 1. March 2024 milestone Mar 15, 2024
@jmao-denver jmao-denver self-assigned this Mar 15, 2024
@jmao-denver jmao-denver marked this pull request as ready for review March 15, 2024 18:25
@jmao-denver jmao-denver merged commit 1c8c11f into deephaven:main Mar 15, 2024
19 checks passed
@jmao-denver jmao-denver deleted the 5255-hide-column_to_numpy_array branch March 15, 2024 19:27
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chipkent chipkent chipkent approved these changes

@elijahpetty elijahpetty Awaiting requested review from elijahpetty

@rcaudy rcaudy Awaiting requested review from rcaudy rcaudy is a code owner

Assignees

@jmao-denver jmao-denver

Labels
NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. python-server-side
Projects
None yet
Milestone
1. March 2024
Development

Successfully merging this pull request may close these issues.

column_to_numpy_array is exposed to users, and should not be.
2 participants
@jmao-denver @chipkent