Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Blink table usage of i, ii, k, and column arrays; address improper memoization sharing between blink and non-blink table copies #5216

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Address Blink table usage of i, ii, k, and column arrays; address improper memoization sharing between blink and non-blink table copies #5216

merged 2 commits into from
Mar 4, 2024

Conversation

rcaudy
Copy link
Member

@rcaudy rcaudy commented Mar 4, 2024

Closes #5214
Closes #5209

@rcaudy
Conditions and formulas applied to blink tables should be allowed to …
05b17ec 
…use i, ii, k, and column arrays.
@rcaudy
Ensure that aggregations and rollups on copied tables (e.g. those res…
ade825d 
…ulting from attribute changes for adding/removing "blink") never use the parent rather than the copy if "isBlink" is different.
@rcaudy rcaudy added bug Something isn't working feature request New feature or request query engine core Core development tasks DocumentationNeeded ReleaseNotesNeeded Release notes are needed labels Mar 4, 2024
@rcaudy rcaudy added this to the 2. February 2024 (end of month) milestone Mar 4, 2024
@rcaudy rcaudy requested a review from nbauernfeind March 4, 2024 18:09
@rcaudy rcaudy self-assigned this Mar 4, 2024
@rcaudy
Copy link
Member Author

rcaudy commented Mar 4, 2024 •
edited
Loading

This tests the first commit nicely:

t=timeTableBuilder().blinkTable(true).period("PT00:00:00.1").build()
u=t.update("Rank=ii", "RowKey=k", "delta=Timestamp_[ii] - Timestamp_[ii-3]")

And then follow on with this to test the second commit:

lb1=u.removeBlink().lastBy("RowKey")
lb2=u.lastBy("RowKey")

@rcaudy rcaudy merged commit 4afb025 into deephaven:main Mar 4, 2024
31 checks passed
@rcaudy rcaudy deleted the rwc-blinkstuff branch March 4, 2024 23:23
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2024
@deephaven-internal
Copy link
Contributor

Labels indicate documentation is required. Issues for documentation have been opened:

Community: https://github.com/deephaven/deephaven.io/issues/3751

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nbauernfeind nbauernfeind nbauernfeind approved these changes

Assignees

@rcaudy rcaudy

Labels
bug Something isn't working core Core development tasks DocumentationNeeded feature request New feature or request query engine ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
2. February 2024 (end of month)
Development

Successfully merging this pull request may close these issues.

Blink tables should allow users to access i, ii, and k Improper Memoization with Blink Table attributes
3 participants
@rcaudy @deephaven-internal @nbauernfeind