Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include all Right Table Values in Match Column #5190

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nbauernfeind
Copy link
Member

Fixes #5184.

I had kept the behavior from DHE, but I suspect we do actually want for match columns to show the right values when there are no rows.

@nbauernfeind nbauernfeind added bug Something isn't working query engine core Core development tasks NoDocumentationNeeded ReleaseNotesNeeded Release notes are needed labels Feb 23, 2024
@nbauernfeind nbauernfeind self-assigned this Feb 23, 2024
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this "weird". I think the commingling of values is "fine", but it feels weird to me to only use the LHS name. Should we create a new name that represents a pair of values? Should we never merge values? The code change is fine, but I want confirmation from someone more user-facing.

@nbauernfeind
Copy link
Member Author

This approach is being abandoned in favor of this:

  • Do not include RHS columns by default (do not merge by default as is today)
  • Add a union parameter that uses LHS column names and merges RHS into them (new feature)
  • Allow RHS renames via the join-list (if the join-list is empty it brings all RHS columns, not jut key-columns; existing behaviors)
  • Fail if joined columns have any name collisions (existing behavior)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Core development tasks March2024 NoDocumentationNeeded query engine ReleaseNotesNeeded Release notes are needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Full Outer Join Does not Properly Display Right-Values on Joined Column Without Match
3 participants