Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python API to access Java server threads #4949

Merged
merged 7 commits into from
Dec 15, 2023
Merged

Python API to access Java server threads #4949

merged 7 commits into from
Dec 15, 2023

Conversation

niloc132
Copy link
Member

Provides access to server thread pools from python, enabling plugin or
dhui component authors to move work off-thread as appropriate, without
introducing their own threads.

Partial #4942

@niloc132 niloc132 added this to the November 2023 milestone Dec 14, 2023
@niloc132 niloc132 added the release blocker A bug/behavior that puts is below the "good enough" threshold to release. label Dec 14, 2023
@jnumainville jnumainville mentioned this pull request Dec 14, 2023
Merged
jmao-denver
jmao-denver reviewed Dec 14, 2023
View reviewed changes
Copy link
Contributor

@jmao-denver jmao-denver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor things (style, docstrings)

jmao-denver
jmao-denver previously approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@jmao-denver jmao-denver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@niloc132
Initial API for python server threads
f8829aa 
Provides access to server thread pools from python, enabling plugin or
dhui component authors to move work off-thread as appropriate, without
introducing their own threads.

Partial deephaven#4942
@niloc132
in-progress pre-review feedback
75ec3a0
@niloc132
Spotless
1c4b0b0
@niloc132
Review feedback
7eaf60d
@niloc132
Throw if double-registered
64c4dbf
@niloc132
doc cleanup
06e5618
@niloc132
Use thread initializer
5c25ad4
@jmao-denver jmao-denver self-requested a review December 15, 2023 00:19
jmao-denver
jmao-denver approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@jmao-denver jmao-denver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reapprove after Java only change

@niloc132 niloc132 merged commit ac70fd3 into deephaven:main Dec 15, 2023
19 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy left review comments

@nbauernfeind nbauernfeind nbauernfeind approved these changes

@jmao-denver jmao-denver jmao-denver approved these changes

@chipkent chipkent Awaiting requested review from chipkent chipkent is a code owner

Assignees
No one assigned
Labels
NoDocumentationNeeded python-server-side release blocker A bug/behavior that puts is below the "good enough" threshold to release. ReleaseNotesNeeded Release notes are needed
Projects
None yet
Milestone
November 2023
Development

Successfully merging this pull request may close these issues.
4 participants
@niloc132 @nbauernfeind @jmao-denver @rcaudy