Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LongWrapper comparison through value instead of object #4940

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

georgecwan
Copy link
Contributor

@georgecwan georgecwan commented Dec 12, 2023

While working with tables partitioned by a column of Long types, I was unable to get constituent tables using LongWrapper objects obtained from the keyTable since there was no override of LongWrapper's equals function.

This change adds an equals and hashCode function to LongWrapper so that comparisons are done on the Long value field of the objects instead of on the addresses of the objects.

@niloc132 niloc132 added the jsapi label Dec 12, 2023
@georgecwan georgecwan merged commit 8614e20 into deephaven:main Dec 13, 2023
24 checks passed
@georgecwan georgecwan deleted the fix-longwrapper-comparison branch December 13, 2023 17:29
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants