Adds InputTableService support for blink tables #4934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds `TablePublisher#inputTable`, which adds a very simple InputTableUpdater implementation to the blink table. Also, some further simplifications in the spirit of deephaven#4923: `InputTableUpdater#getDescription`, `InputTableUpdater#getTable`, and `InputTableUpdater#canEdit` were removed to due no usages. Fixes deephaven#4915
devinrsmith
added
NoDocumentationNeeded
NoReleaseNotesNeeded
devinrsmith
requested review from
nbauernfeind,
niloc132,
rcaudy,
chipkent and
jmao-denver
as code owners
rcaudy
reviewed
Dec 12, 2023
rcaudy
reviewed
Dec 13, 2023
Also, updates InputTableService to use async methods.
rcaudy
reviewed
Dec 13, 2023
server/src/main/java/io/deephaven/server/table/inputtables/InputTableServiceGrpcImpl.java
Show resolved
Hide resolved
rcaudy
reviewed
Dec 13, 2023
engine/table/src/main/java/io/deephaven/stream/TablePublisher.java
Outdated
Show resolved
Hide resolved
rcaudy
approved these changes
Dec 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
TablePublisher#inputTable, which adds a very simpleInputTableUpdaterimplementation to the blink table.Also, some further simplifications in the spirit of #4923:
InputTableUpdater#getDescription,InputTableUpdater#getTable, andInputTableUpdater#canEditwere removed due to no usages.Fixes #4915