Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIx #4928: make BarrageSubscriptionImpl manage the created BarrageTable #4929

Closed
wants to merge 2 commits into from
Closed

FIx #4928: make BarrageSubscriptionImpl manage the created BarrageTable #4929

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3570b9f
BarrageSubscriptionImpl should be a liveness artifact and should mana…
abaranec Dec 10, 2023
b7900be
Merge remote-tracking branch 'origin/main' into abaranec_barragemanag…
abaranec Dec 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion java-client/barrage/src/main/java/io/deephaven/client/impl/BarrageSubscriptionImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import io.deephaven.base.log.LogOutput;
import io.deephaven.chunk.ChunkType;
import io.deephaven.engine.exceptions.RequestCancelledException;
import io.deephaven.engine.liveness.LivenessArtifact;
import io.deephaven.engine.liveness.ReferenceCountedLivenessNode;
import io.deephaven.engine.rowset.RowSet;
import io.deephaven.engine.rowset.WritableRowSet;
Expand Down Expand Up @@ -54,7 +55,7 @@
* Users may call {@link #entireTable} or {@link #partialTable} to initiate the gRPC call to the server. These methods
* return a {@link Future<BarrageTable>} to the user.
*/
public class BarrageSubscriptionImpl extends ReferenceCountedLivenessNode implements BarrageSubscription {
public class BarrageSubscriptionImpl extends LivenessArtifact implements BarrageSubscription {
private static final Logger log = LoggerFactory.getLogger(BarrageSubscriptionImpl.class);

private final String logName;
Expand Down Expand Up @@ -94,6 +95,7 @@ public BarrageSubscriptionImpl(
final TableDefinition tableDefinition = schema.tableDef;
checkForCompletion = new CheckForCompletion();
resultTable = BarrageTable.make(executorService, tableDefinition, schema.attributes, checkForCompletion);
manage(resultTable);

final MethodDescriptor<FlightData, BarrageMessage> subscribeDescriptor =
getClientDoExchangeDescriptor(options, schema.computeWireChunkTypes(), schema.computeWireTypes(),
Expand Down
Loading