Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ Client: Arrow deprecation; more style guide #4859

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

kosak
Copy link
Contributor

@kosak kosak commented Nov 19, 2023

This PR:

  • changes more Arrow calls to the corresponding Result-returning methods.
  • makes more style guide changes

@kosak kosak added NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. labels Nov 19, 2023
@kosak kosak self-assigned this Nov 19, 2023
jcferretti
jcferretti previously approved these changes Nov 20, 2023
@kosak kosak force-pushed the kosak_absl-dates-etc branch 3 times, most recently from 3001714 to 0c85e1c Compare November 29, 2023 03:56
@kosak kosak changed the title C++ Client: use absl for dates; Arrow deprecation; more style guide C++ Client: Arrow deprecation; more style guide Nov 29, 2023
@kosak kosak enabled auto-merge (squash) November 29, 2023 04:40
@kosak kosak merged commit 3d8f9e2 into deephaven:main Nov 29, 2023
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2023
@kosak kosak deleted the kosak_absl-dates-etc branch November 29, 2023 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants