Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ Client: avoid deprecated Arrow methods, plus conform to coding style #4857

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

kosak
Copy link
Contributor

@kosak kosak commented Nov 19, 2023

The changes in this PR are:

  1. Change a bunch of parameter names to conform to the style guide
  2. Change our GetFlightStreamReader method to return a unique_ptr rather than shared_ptr (we were inadvertantly "upgrading" Arrow's returned unique_ptr to a shared_ptr)
  3. Reorder the two OkOrThrow methods in arrow_util.h so one can actually successfully call the other (they were in the wrong declaration order, so one couldn't see the other).
  4. Change a couple of Arrow calls (DoGet and Next) to use the value-returning versions rather than the deprecated versions with out parameters)
  5. Remove a needless using namespace std;

@kosak kosak merged commit 89357e4 into deephaven:main Nov 20, 2023
16 checks passed
@kosak kosak deleted the kosak_deprecated-arrow-1 branch November 20, 2023 13:50
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants