C++ Client: avoid deprecated Arrow methods, plus conform to coding style #4857
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR are:
GetFlightStreamReader
method to return aunique_ptr
rather thanshared_ptr
(we were inadvertantly "upgrading" Arrow's returnedunique_ptr
to ashared_ptr
)OkOrThrow
methods inarrow_util.h
so one can actually successfully call the other (they were in the wrong declaration order, so one couldn't see the other).DoGet
andNext
) to use the value-returning versions rather than the deprecated versions with out parameters)using namespace std;