-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs CI Upload Versioned Artifacts #4853
Merged
stanbrub
merged 37 commits into
deephaven:main
from
stanbrub:docs-ci-version-improvements
Nov 21, 2023
Merged
Docs CI Upload Versioned Artifacts #4853
stanbrub
merged 37 commits into
deephaven:main
from
stanbrub:docs-ci-version-improvements
Nov 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanbrub
requested review from
devinrsmith,
jcferretti,
JamesXNelson,
mofojed and
rcaudy
as code owners
November 16, 2023 22:58
stanbrub
changed the title
Docs ci version improvements
Docs CI Upload Versioned Artifacts
Nov 16, 2023
devinrsmith
requested changes
Nov 16, 2023
devinrsmith
reviewed
Nov 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you've got some conflicts w/ main...
Happy to approve this soon. The next step after this PR would be to actually publish based on release branches to named subdirectories of deephaven.io.
) Replaces the annotation processor previously used with a doclet implementation. This still emits a .d.ts file using Java mirror/element types for accurate type information, but now is able to traverse Javadoc trees as well, and produces corresponding typedoc tags or markdown. The typedoc tool now generates HTML for deployment to the Deephaven docs website. Additionally, this branch produces a tarball suitable for deployment as an npm module, containing only those generated types. However, this output is still untested.
devinrsmith
reviewed
Nov 21, 2023
devinrsmith
requested changes
Nov 21, 2023
devinrsmith
requested changes
Nov 21, 2023
devinrsmith
approved these changes
Nov 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated Docs CI workflow to produce the following artifacts:
Also, added appropriate verbiage to the RELEASE.MD.
These end up in the Summary for the Workflow and can be download/uploaded to Github release assets similar to the ones produced by the Publish CI.