Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply query scope ctx on formula aggregation #4839

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Apply query scope ctx on formula aggregation #4839

merged 2 commits into from
Nov 17, 2023

Conversation

jmao-denver
Copy link
Contributor

Fixes #4834

@jmao-denver jmao-denver added this to the November 2023 milestone Nov 15, 2023
@jmao-denver jmao-denver self-assigned this Nov 15, 2023
chipkent
chipkent reviewed Nov 15, 2023
View reviewed changes
py/server/tests/test_table.py Outdated Show resolved Hide resolved
py/server/tests/test_table.py Show resolved Hide resolved
@jmao-denver jmao-denver marked this pull request as draft November 15, 2023 20:22
@jmao-denver jmao-denver marked this pull request as ready for review November 16, 2023 16:03
@jmao-denver jmao-denver merged commit 953d0f2 into deephaven:main Nov 17, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2023
@jmao-denver jmao-denver deleted the 4834-agg-formula-qscope branch December 18, 2023 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chipkent chipkent chipkent approved these changes

@rcaudy rcaudy Awaiting requested review from rcaudy rcaudy is a code owner

Assignees

@jmao-denver jmao-denver

Labels
NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. python-server-side
Projects
None yet
Milestone
November 2023
Development

Successfully merging this pull request may close these issues.

Python scope does not work properly in agg formulas
3 participants
@jmao-denver @chipkent @rcaudy