Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply typing.Literal whereever appropriate #4803

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Apply typing.Literal whereever appropriate #4803

merged 2 commits into from
Nov 10, 2023

Conversation

jmao-denver
Copy link
Contributor

Fixes $4795

@jmao-denver jmao-denver added this to the November 2023 milestone Nov 9, 2023
@jmao-denver jmao-denver self-assigned this Nov 9, 2023
rcaudy
rcaudy reviewed Nov 10, 2023
View reviewed changes
Copy link
Member

@rcaudy rcaudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have more cases in the Parquet code, or Kafka code?

@jmao-denver
Copy link
Contributor Author

jmao-denver commented Nov 10, 2023 •
edited
Loading

Do we have more cases in the Parquet code, or Kafka code?

They do seem to be a fertile ground for that but I didn't see any there.

@jmao-denver jmao-denver merged commit 318c2e2 into deephaven:main Nov 10, 2023
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2023
@jmao-denver jmao-denver deleted the 4795-typing-literal branch December 18, 2023 17:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rcaudy rcaudy rcaudy left review comments

@chipkent chipkent chipkent approved these changes

Assignees

@jmao-denver jmao-denver

Labels
NoDocumentationNeeded NoReleaseNotesNeeded No release notes are needed. python-server-side
Projects
None yet
Milestone
November 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@jmao-denver @chipkent @rcaudy