Add support for MultiXYErrorBarSeries, MultiOHLCSeries figures #4763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- There was no error being recorded for unsupported multi series - Add JsProperty tag to JsFigure.getErrors so the UI can actually see the errors - Fixes deephaven#4709
- Wasn't wired up at all
- Wasn't wired up at all
mofojed
commented
Nov 2, 2023
Comment on lines
+548
to
+550
| multiXYErrorBarSeries.lineColorSeriesNameTointMap(), | ||
| multiXYErrorBarSeries.lineColorSeriesNameToStringMap(), | ||
| multiXYErrorBarSeries.lineColorSeriesNameToPaintMap()))); |
There was a problem hiding this comment.
A lot of these methods seem to be shared by all the AbstractPartitionedTableHandleMultiSeries types, and could probably be cleaned up further. I haven't done that, as I didn't want to change too much in this change, and I'm not entirely sure how the autogenerated parts of these series works.
mofojed
added
NoDocumentationNeeded
NoReleaseNotesNeeded
niloc132
reviewed
Nov 9, 2023
| @@ -201,6 +203,8 @@ public Promise<JsFigure> refetch() { | |||
| .map(chartDescriptor -> new JsChart(chartDescriptor, this)).toArray(JsChart[]::new); | |||
| JsObject.freeze(charts); | |||
|
|
|||
| errors = JsObject.freeze(descriptor.getErrorsList().asList().toArray(new String[0])); | |||
There was a problem hiding this comment.
maybe just array.slice?
Suggested change
| errors = JsObject.freeze(descriptor.getErrorsList().asList().toArray(new String[0])); | |
| errors = JsObject.freeze(descriptor.getErrorsList().slice()); |
Also have to change the type of the field and the getter
niloc132
reviewed
Nov 9, 2023
plugin/figure/src/main/java/io/deephaven/figure/FigureWidgetTranslator.java
Outdated
Show resolved
Hide resolved
niloc132
reviewed
Nov 9, 2023
plugin/figure/src/main/java/io/deephaven/figure/FigureWidgetTranslator.java
Outdated
Show resolved
Hide resolved
…anslator.java Co-authored-by: Colin Alworth <[email protected]>
…anslator.java Co-authored-by: Colin Alworth <[email protected]>
- Just use .slice()
niloc132
approved these changes
Nov 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JsPropertyinsteadbender_figure-errorspushed for this, ready to open up a PR for.