From cd5abf82f145b26ca66fda7a5b62bd4b35eb6780 Mon Sep 17 00:00:00 2001 From: Corey Kosak Date: Mon, 1 Jul 2024 22:13:02 -0400 Subject: [PATCH] =?UTF-8?q?fix(cppclient):=20Clarify=20a=20comment=20expla?= =?UTF-8?q?ining=20why=20a=20test=20is=20disabled,=20=E2=80=A6=20(#5705)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit …and fix a bug in the test --- cpp-client/deephaven/tests/src/ungroup_test.cc | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/cpp-client/deephaven/tests/src/ungroup_test.cc b/cpp-client/deephaven/tests/src/ungroup_test.cc index 71621afe8bc..f946d171edc 100644 --- a/cpp-client/deephaven/tests/src/ungroup_test.cc +++ b/cpp-client/deephaven/tests/src/ungroup_test.cc @@ -5,15 +5,17 @@ #include "deephaven/tests/test_util.h" namespace deephaven::client::tests { -// TODO(kosak): This test is currently disabled (by membership in the [.] test group, because we -// don't yet deserialize the grouped column correctly. +// TODO(kosak): This test is currently disabled (by membership in the [.] test group). +// The reason is because each cell in the grouped column comes back as the Arrow type list, +// but the library does not currently know how to deserialize Arrow list types. TEST_CASE("Ungroup columns", "[.]") { auto tm = TableMakerForTests::Create(); auto table = tm.Table(); table = table.Where("ImportDate == `2017-11-01`"); - auto by_table = table.Where("Ticker == `AAPL`").View("Ticker", "Close").View("Ticker"); + auto by_table = table.Where("Ticker == `AAPL`").View("Ticker", "Close").By("Ticker"); + std::cout << by_table.Stream(true) << '\n'; auto ungrouped = by_table.Ungroup("Close"); std::vector ticker_data = {"AAPL"};