From c80370489538371611fcc7d311cfec88e4936148 Mon Sep 17 00:00:00 2001 From: Mike Bender Date: Fri, 12 Jul 2024 11:55:39 -0400 Subject: [PATCH] fix: Remove table attribute size cutoff limit (#5749) - Cherry picked from `5a96faa3aed4268c79118c43655457f77dc36f2b` - No need to have a limit on this anymore - Tested with the snippet in the ticket - Fixes #5627 - Fixes DH-17392 in DHE --- .../io/deephaven/extensions/barrage/util/BarrageUtil.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/extensions/barrage/src/main/java/io/deephaven/extensions/barrage/util/BarrageUtil.java b/extensions/barrage/src/main/java/io/deephaven/extensions/barrage/util/BarrageUtil.java index a9e82f3907c..44b3d5d5fa2 100755 --- a/extensions/barrage/src/main/java/io/deephaven/extensions/barrage/util/BarrageUtil.java +++ b/extensions/barrage/src/main/java/io/deephaven/extensions/barrage/util/BarrageUtil.java @@ -102,8 +102,6 @@ public class BarrageUtil { /** The name of the attribute that indicates that a table is flat. */ public static final String TABLE_ATTRIBUTE_IS_FLAT = "IsFlat"; - private static final int ATTR_STRING_LEN_CUTOFF = 1024; - private static final String ATTR_DH_PREFIX = "deephaven:"; private static final String ATTR_ATTR_TAG = "attribute"; private static final String ATTR_ATTR_TYPE_TAG = "attribute_type"; @@ -185,8 +183,7 @@ public static Map attributesToMetadata( final Object val = entry.getValue(); if (val instanceof Byte || val instanceof Short || val instanceof Integer || val instanceof Long || val instanceof Float || val instanceof Double || - val instanceof Character || val instanceof Boolean || - (val instanceof String && ((String) val).length() < ATTR_STRING_LEN_CUTOFF)) { + val instanceof Character || val instanceof Boolean || val instanceof String) { // Copy primitives as strings putMetadata(metadata, ATTR_ATTR_TAG + "." + key, val.toString()); putMetadata(metadata, ATTR_ATTR_TYPE_TAG + "." + key, val.getClass().getCanonicalName());