From 0c79e2e1bb6b3128dab200e7d15edf5563389eea Mon Sep 17 00:00:00 2001 From: Devin Smith Date: Wed, 13 Dec 2023 15:49:57 -0800 Subject: [PATCH] update comment --- .../java/io/deephaven/stream/TablePublisher.java | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/engine/table/src/main/java/io/deephaven/stream/TablePublisher.java b/engine/table/src/main/java/io/deephaven/stream/TablePublisher.java index 7ce8cb9c6b4..5717ec6adab 100644 --- a/engine/table/src/main/java/io/deephaven/stream/TablePublisher.java +++ b/engine/table/src/main/java/io/deephaven/stream/TablePublisher.java @@ -10,6 +10,7 @@ import io.deephaven.util.annotations.TestUseOnly; import javax.annotation.Nullable; +import java.util.Collection; import java.util.Map; import java.util.Objects; import java.util.function.Consumer; @@ -174,16 +175,11 @@ public boolean isAlive() { /** * Creates a new {@link Table#BLINK_TABLE_ATTRIBUTE blink table} with its {@link Table#getAttribute(String) * attribute} {@value Table#INPUT_TABLE_ATTRIBUTE} set to an {@link InputTableUpdater} implementation based on - * {@code this}. This is primarily useful for existing code that already works with {@link InputTableUpdater} - new - * code should prefer to work directly with {@code this}. - * - *

- * Unlike the interface suggests, the {@link InputTableUpdater} implementation does not block on - * {@link InputTableUpdater#add(Table) add}; furthermore, it does not implement - * {@link InputTableUpdater#addAsync(Table, InputTableStatusListener) addAsync}, - * {@link InputTableUpdater#delete(Table) delete}, nor - * {@link InputTableUpdater#deleteAsync(Table, InputTableStatusListener) deletAsync}, and so it may not be - * applicable in all contexts. + * {@code this}. The implementation's definition of "completed" with respect to {@link InputTableUpdater#add(Table)} + * and {@link InputTableUpdater#addAsync(Table, InputTableStatusListener)} matches the semantics provided by + * {@link #add(Table)} - that is, "completed" means that a snapshot of {@code newData} has been taken and handed + * off. The implementation does not implement {@link InputTableUpdater#delete(Table)} nor + * {@link InputTableUpdater#deleteAsync(Table, InputTableStatusListener)}. * *

* May return {@code null} if invoked more than once and the initial caller does not enforce strong reachability of