birthday: Set correctly for existing wallets. #2385
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
reviewed
Jun 19, 2024
spv/sync.go
Outdated
| @@ -12,6 +12,7 @@ import ( | |||
| "sync/atomic" | |||
| "time" | |||
|
|
|||
| "decred.org/dcrwallet/v4/chain" | |||
There was a problem hiding this comment.
i realize this is a draft, but don't depend on this package (poorly named, but is the rpc-mode syncer) from the spv syncer.
There was a problem hiding this comment.
moving the correct code into (*Wallet).SetBirthState seems more appropriate.
There was a problem hiding this comment.
JoeGruffins
force-pushed
the
existingbirthday
branch
from
594fb24
to
d54c90b
Compare
JoeGruffins
force-pushed
the
existingbirthday
branch
from
d54c90b
to
0401f05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.