pool: Make endpoint tests more robust and fix race. #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jholdstock
reviewed
Sep 20, 2023
jholdstock
reviewed
Sep 20, 2023
davecgh
force-pushed
the
more_robust_endpoint_tests
branch
from
70baf85
to
008484e
Compare
This modifies the endpoint tests to respect the context when sending to and receiving from the endpoint channels similar to what was recently done for the chainstate tests. It also fixes a race in the test due to the add callback being invoked in the run goroutine.
davecgh
force-pushed
the
more_robust_endpoint_tests
branch
from
008484e
to
261b6f9
Compare
jholdstock
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the endpoint tests to respect the context when sending to and receiving from the endpoint channels similar to what was recently done for the chainstate tests.
It also fixes a race in the test due to the add callback being invoked in the run goroutine.